Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nikita fix badge categories count and assignment issues - backend #1153

Open
wants to merge 3 commits into
base: development
Choose a base branch
from

Conversation

ArtemisNyx3
Copy link

@ArtemisNyx3 ArtemisNyx3 commented Nov 17, 2024

Description

Pasted image 20241109034550

Related PRS (if any):

To test this backend PR you need to checkout the #2877frontend PR.

Main changes explained:

  • fixed badge assignment for "total hours in category" type badges

How to test:

  1. check into current branch
  2. do npm install , npm run build and npm run start to run this PR locally
  3. Clear site data/cache
  4. log as admin user
  5. go to Other Links → User Management → Select a user

Testing

  1. Check if assigning a new badge increses the count of other badges

  2. in userProfileJobs.js comment out '* * * *' line to run the cronjob for badge assigments immediately (Line 9. and comment out Line 10)
    image

  3. in userHelper.js go to Line 2009 and follow the comments
    image

  4. Assign hours in Volunteer Times in Userprofile and wait for the cronjob to run (Badge assigned comment implies a cycle of badge assigments is done)
    image

  5. Verify if the bade assigned follows the criteria

  6. Verify if badges of higher hour count replace lower hour count badges

Screenshots or videos of changes:

Note:

Include the information the reviewers need to know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant